Forum Discussion

gus's avatar
gus
Contributor
10 years ago

Message posted to wrong log folder

Hi,   I'm completely clueless what this strange behavior is posted by: I append a log folder to the one on the top of the folder stack, but TC only posts entries to this appended folder only when e...
append
appendfolder
Log
log folder
pop
popfolder
push
pushfolder
  • joseph_michaud's avatar
    joseph_michaud
    10 years ago

    A simple test shows that calling Log.PushFolder() on the same folder twice does actually push that folder twice onto the stack.  Popping it off twice is appropriate.  (attached the foldertest that I used)

     

    I can reproduce your problem only if I push an invalid folder ID:

     

    function ReadGlobalConfig()
{
  var GetInfrastructuralLogID = Log.CreateFolder("GetInfrastructuralLog", null, pmLowest);
  Log.PushLogFolder(GetInfrastructuralLogID);
  
  var logId = Log.AppendFolder("Reading project suite configuration settings");
var invalidID = 5;
Log.PushLogFolder(invalidID);
  
  Log.Message("Method 1", null, pmLowest);
  Log.Message("Method 2", "", pmLowest, null, null, logId);
  Log.Message("Method 1", null, pmLowest);
  
  Log.PopLogFolder();
  Log.PopLogFolder(); // Infra log
}

     

    Other than that, I've got nothing.

gus's avatar
gus
Contributor

Hi Joseph,

 

I'm afraid I cannot post a self-contained example, since my test project consists of thousands of Jscript code across many scripts, which, apart from being confidential, are too complex to get familiar with just for the sake of this issue.

 

However, I have a guess, and please confirm if this can cause a problem.

 

Say you have the following log folders (using folder IDs for identification):

 

- 0
  - 2
    - 6
  - 3
- 1
  - 4
  - 5

 

Assume folder 2 is on the top of the stack, so the stack is like this: 0, 2.

 

QUESTION: What happens if I push folder 2 to the top? Will the stack be 0, 2, 2, or will it remain 0,2?

 

If it remains 0, 2, than the issue may be caused by the fact that I push the infrstructural log folder to the top of the stack, and I also pop it from the stack at the end of my routine, but if the folder was alread at the top of the stack, I finally remove more items from the stack:

  1. Two push ops at the beginning add only one folder to the stack if the first was already on the top
  2. The two pop ops remove two folders regardless of how many was added.

Please confirm which is the way TC works. I came to this potential answer by realizing that another test using this same shared portion of code did not produce the same problem, and I also realized the difference between the tests was that the folder pushed in the Log.PushLogFolder(GetInfrastructuralLogID()); was already the top folder in one and was not in the other.

joseph_michaud's avatar
joseph_michaud
Moderator
10 years ago

A simple test shows that calling Log.PushFolder() on the same folder twice does actually push that folder twice onto the stack.  Popping it off twice is appropriate.  (attached the foldertest that I used)

 

I can reproduce your problem only if I push an invalid folder ID:

 

function ReadGlobalConfig()
{
  var GetInfrastructuralLogID = Log.CreateFolder("GetInfrastructuralLog", null, pmLowest);
  Log.PushLogFolder(GetInfrastructuralLogID);
  
  var logId = Log.AppendFolder("Reading project suite configuration settings");
var invalidID = 5;
Log.PushLogFolder(invalidID);
  
  Log.Message("Method 1", null, pmLowest);
  Log.Message("Method 2", "", pmLowest, null, null, logId);
  Log.Message("Method 1", null, pmLowest);
  
  Log.PopLogFolder();
  Log.PopLogFolder(); // Infra log
}

 

Other than that, I've got nothing.

  • Manfred_F's avatar
    Manfred_F
    Regular Contributor
    9 years ago

    I also had a log item positioning issue.

    Error and Warning Log items were not positioned on the expected Location, but some positions above, one or two log Levels further indented.

     

    This disappeared as I occasionally changed my log Event handling.

    Before, I had implemented eventhandlers only for Message, Event and error.

    When I added Event handlers for Checkpoint and Warning, the Problems were gone..

     

    Curious..

    • gus's avatar
      gus
      Contributor
      9 years ago

      Indeed... I don't remember clearly, but maybe I could catch the problem (maybe a pop-folder in a different place wasn't always invoked), but then I dropped the idea of maintaining two parallel 2nd level folders in the log, since it proved to be hard to track things from historical point of view, what happened first, and what next.

      • Manfred_F's avatar
        Manfred_F
        Regular Contributor
        9 years ago

        After some more Investigation, it is clear, that implementation or non-implementation of callbacks does not have an effect.

         

        What does effect the log is whether a log entry generated by my own logging library object does ist logging with or without a screenshot comprised.

        With no screenshot, the new log entry is positioned correctly.

        With a screenshot attached, the log entry is positioned as first log entry in the currently active log Folder.

         

        My Workaround is to generate a new log Folder just for logging the screenshot.