Forum Discussion

Mark1's avatar
Mark1
Contributor
6 years ago

If statement for VisibleOnScreen is failing when object is not on screen

I have a method where if the a specific dialog box is VisibleOnScreen it will click the ok button and carry on else it just carries on as normal. This dialog box is just a warning that the software b...
tristaanogre's avatar
tristaanogre
Esteemed Contributor

Your "Set" call... are you using anything like a WaitChild or FindChild or anything to find the Dialog box?  The reason I ask is that you cannot call the "VisibleOnScreen" property of an object that does not exist.  Your Set call, if the dialog isn't actually extant in memory of your application, will return a Null value which HAS no properties.  You should always check for "Exists" before you attempt to interact.

Mark1's avatar
Mark1
Contributor
6 years ago

No, what I have in my example is exactly what I have in my method. So would the following work

 

Set U=Sys.Process("softwareName").WPFObject("HwndSource: PopupRoot", "").WPFObject("PopupRoot", "", 1).WPFObject("Decorator", "", 1).WPFObject("NonLogicalAdornerDecorator", "", 1).WPFObject("Grid", "", 1).WaitChild("softwareName",2000)
If U.VisibleOnScreen Then
Sys.Process("softwareName").WPFObject("HwndSource: PopupRoot", "").WPFObject("PopupRoot", "", 1).WPFObject("Decorator", "", 1).WPFObject("NonLogicalAdornerDecorator", "", 1).WPFObject("Grid", "", 1).WPFObject("messagecontent").WPFObject("grid1").WPFObject("Border", "", 1).WPFObject("StackPanel", "", 1).WPFObject("StackPanel", "", 1).WPFObject("left").Click()
Log.Message" Button was clicked"
Else Log.Message" Button was not clicked"
End If

  • m_essaid's avatar
    m_essaid
    Valued Contributor
    6 years ago

    Hi,

    Robert just said what you need, even you check the "exists" then the "visible" in a nested condition, even you use wait methods that accepts to wait for objects that may not exist.

  • tristaanogre's avatar
    tristaanogre
    Esteemed Contributor
    6 years ago

    No, it will still not work.  If WaitChild returns and fails to find the designatated object, WaitChild returns an empty object which has no methods and only a single property, that being the "Exists" property set to False.  So, you cannot check "VisibleOnScreen" on the result of WaitChild... you should still check for "Exists" first before you do any additional checks or processes.

    • Mark1's avatar
      Mark1
      Contributor
      6 years ago

      Ok, I think I understand better, I was overcomplicating it prior. This is what I currently have, I am checking if the dialogbox exists and if it does then it checks is it visible and if so clicks the button else carries on as normal.

       

      If Sys.Process("SoftwareBeingTested").WPFObject("HwndSource: PopupRoot", "").WPFObject("PopupRoot", "", 1).WPFObject("Decorator", "", 1).WPFObject("NonLogicalAdornerDecorator", "", 1).WPFObject("Grid", "", 1).Exists Then

      Set U=Sys.Process("SoftwareBeingTested").WPFObject("HwndSource: PopupRoot", "").WPFObject("PopupRoot", "", 1).WPFObject("Decorator", "", 1).WPFObject("NonLogicalAdornerDecorator", "", 1).WPFObject("Grid", "", 1)
      If U.VisibleOnScreen Then
      Sys.Process("SoftwareBeingTested").WPFObject("HwndSource: PopupRoot", "").WPFObject("PopupRoot", "", 1).WPFObject("Decorator", "", 1).WPFObject("NonLogicalAdornerDecorator", "", 1).WPFObject("Grid", "", 1).WPFObject("messagecontent").WPFObject("grid1").WPFObject("Border", "", 1).WPFObject("StackPanel", "", 1).WPFObject("StackPanel", "", 1).WPFObject("left").Click()
      Log.Message" Button was clicked"
      Else Log.Message"Button was clicked"
      End If
      Else Log.Message" Dialog box did not exist"
      End If

      But even with checking at the very beginning if the dialog box exists I am still getting an error whenever I start the test and the dialog box does not appear, the code works fine if it does appear.