Accessing internalCustomFields for Triggers in Collaborator
Hello world, I can use the http://collaborator.server/services/json/v1 API with the following JSON body to get data about a review. [ { "command" : "ReviewService.findReviewById", "args" : { "reviewId" : "42" } }] Specifically, it includes the following internalCustomFields key: "internalCustomFields" : [ { "name" : "JiraIssueId", "value" : [ "10600" ] }, { "name" : "ExternalTaskId", "value" : [ "" ] } ] I would like to use this JiraIssueId field for a review as an argument to one of the configurable Triggers (say Review Phase Changed for example). Does anyone know how I would access this internal field? I know I can use ${review.custom.foo} for visible custom fields that I create, but the internal custom fields are not documented in the http://collaborator.server/manual/index.html?admin_var_subst.html documentation. I've tried ${review.internal.JiraIssueId}, ${review.internalCustomFields.JiraIssueId}, and ${review.custom.JiraIssueId} but none of them work (giving me the following error) Error: Invalid input: Parameters: ${review.internalCustom.JiraIssueId} is not a valid substitution keyword Thanks for any help! Best, ~Chris
How to access review files vai JSON or the CLI Client
I have a case where I need to run a 3-rd party tool in order to provide a textual diff of some binary files. Files are stored in Bitbucket and a Collaborator review is created when a pull request is made. I'd like to insert the textual diff as a file into the peer review, triggered by the Added File Trigger. In that trigger, I'd need to get all the files that were added, identify which ones were the custom binary files and then download the last two versions and send it to the 3-rd party diff tool. The result of that diff will be added as a new file into the reivew. I will potentially need to scan old reviews or reviews where the Added File Trigger failed to add the diff, and so a JSON or cli client solution would be ideal, rather than just relying upon the Added File Trigger variable substitutions. I've been unable to identify any way of getting a list of files via JSON or the CLI client, nor any JSON or CLI client commands to retrive files. Does anybody have any suggestions on how to accomplish this? Theoretically, if I had enough information, I could go to git and collect data from it, however, the files already exist on the Collaborator server, and having to download the git repository for every changeset / Added File Trigger seems excessive. Thank you
Perforce ensure review completed
I seem to be having some trouble getting a script to ensure a review was completed to work. I don’t seem to get any kind of status from ccollab.exe. I used this command: C:\CollaboratorClient\ccollab.exe --url http://someurl:8080/ --scm Perforce --p4port {Perforceserver} --p4client CollabTrigger --p4user {p4user ID} --p4passwd {password} admin trigger ensure-reviewed 175817 The status always seems to be empty when going through the perforce trigger and I can submit anything. If I try the above command manually I get: ERROR: SCM system communication problem: This trigger must be configured as change-content. Contact your Perforce administrator to perform the change. I have the Perforce trigger as follows: p4collab change-content //depot/P4validation/... "perl %//Scripts/p4_collab.pl% %serverhost% %changelist% %client%" I’ve tried to find the renumbering script that is linked on this page to see if that is my problem. https://support.smartbear.com/collaborator/docs/source-control/perforce.html Perforce version 2015.1 Collab version 11.4 I'm probably missing something easy so any help is appreciated. ~jeff
create-review post commit hook - password management and participants
Hello Is there any tutorial on how to get this working in a production environment? Especially useful would be some hints on how: 1. the hook should manage the required passwords ( ccollab-admin-trigger-create-review) (we use LDAP). 2.we can control the participants of the review (ie. like a per-user or per-source branch template?I imagine this could be done with some "custom scripting" but since it's probably a very popularrequest is there some built-in support or best practice?)Log all activities of users and admins in Collaborator
In a Large enterprise there will be multiple admins. To track who has done what, Admin should be able to get the log of all users activities. Like, Disabling and Enabling review templates, Disabling and enabling users or adding users etc. In simple terms a log should be generated for every activity happens in Collaborator through all the ways. ex: GUI, API, Collab client, Thirdpart clients, Commands etc.
Ability to disable automatic changes of review progress on Action Items list
Our workflow is such that we want to clearly define when control of a review moves to a different participant. For example, I create a review and annotate it, and then move it to the inspect phase. The review progress then appears in my action items list (and on the system tray window) as "Waiting for comments". However, as soon as the reviewer makes their first comment, it switches back to Perform, which is a nuisance since frequently the reviewer is still working on the review - they may find that a later file answers a question they'd asked, so they go back and delete an earlier comment, or edit one. The result is that I start responding to a comment which then gets updated or deleted by the reviewer, who isn't expecting me to have resumed work on the review since they haven't yet clicked "Wait". It would be nice to have an option whereby Collaborator will leave the review progress as it is until the "Active" participant(s) click "Wait" to wait for further activity. This way, the reviewer can add/edit/delete their comments, approve files etc until they're happy that it's ready to pass back to the author, and only then have the author notified that it's ready for them again. Similarly, when the author then responds to the comments, the same functionality would prevent the reviewer from being asked to respond to the comments until the author had finished writing them. This would not need to prevent participants from participating at any time, as it is very useful to have this ability - it would just prevent one person's changes from causing other participants to be notified and the review progress on their action lists to change.
