VB script : Function with return value and argument

Hi Christopher,



Your example is completely incorrect :) I believe you are mixing Visual Basic and VBScript languages.

Here is a correct version of your function



Function example1(ByVal id)

if( id = 1234) Then

  example1 = false

  Exit Function

End if



if( id = 4321) Then

  example1 = false

  Exit Function

End if



example1 = true



End Function



You can learn more about VBScript here

http://msdn.microsoft.com/en-us/library/t0aew7h6%28VS.85%29.aspx

or download an offline document

http://www.microsoft.com/downloads/details.aspx?FamilyID=01592C48-207D-4BE1-8A76-1C4099D7BBB9&displaylang=en

okay...i agree with you that a mixed both languages.



now i have another problem.



Code :



Sub testcall1()

Dim failed

failed = example1(4142)

writepoducal(4142,8.2,failed)



End Sub





Function writeproducol(ByVal id,byVal version,byVal failed2)

    

  If (failed2) Then

        Call Aliases.EXCEL.wndXLMAIN.XLDESK.EXCEL6.Keys(id&";test-case;Failed;"&version&";;;;[Enter]")

  Else  

        Call Aliases.EXCEL.wndXLMAIN.XLDESK.EXCEL6.Keys(id&";test-case;Passed;"&version&";;;;[Enter]")

 

  End If

End Function



I got a errormassage at line "failed = example1(4142)"

reason : type incompatibility



got a hint?

Got 2 hints ;)

1. Misspelling in function call ("writepoducal" instead of "writeproducol")


2. Since writeproducol doesn't return value, you should call it without brackets

Sub testcall1()

Dim failed

failed = example1(4142)

writeproducol 4142, 8.2, failed

End Sub



Function writeproducol(ByVal id,byVal version,byVal failed2)

    

  If (failed2) Then

        Call Aliases.EXCEL.wndXLMAIN.XLDESK.EXCEL6.Keys(id&";test-case;Failed;"&version&";;;;[Enter]")

  Else  

        Call Aliases.EXCEL.wndXLMAIN.XLDESK.EXCEL6.Keys(id&";test-case;Passed;"&version&";;;;[Enter]")

 

  End If

End Function

I missspelled it just in the thread...but the line : failed = example1(4142) throws the error massage "type incompatibility"

Wanna see the original code? Maybe there is my mistake

yes, please post the original code here

Sub test()

  Dim failed

  failed = LinkParameterPosMM(1234)

  writeproducol 4142, 8.2, failed

End Sub

-----------------------------------------------------------

Function LinkParameterPosMM(ByVal id)



  Dim waiter

  Set waiter = Sys.Process("doors")

  Dim failed

  Call Aliases.doors.wndDOORSWindow.MainMenu.Click("MERAN|Parameter Manager|Link Parameters")

  failed = dxlexsists(id)

  If(failed = true) Then

    LinkParameterPosMM = false

    Exit Function

  End If

 

  Call waiter.WaitWindow("DOORSMessageWindow", "DOORS",1,50000)

  Call Aliases.doors.wndDOORS.btnBest_tigen.ClickButton

  failed = dxlexsists(id)

  If(failed = true) Then

    LinkParameterPosMM=false

    Exit Function

  End If

 

  LinkParameterPosMM=true

End Function

-------------------------------------------------------------------------------------

Function writeproducol(ByVal id,ByVal version,ByVal failed)

    

  If (failed) Then

        Call Aliases.EXCEL.wndXLMAIN.XLDESK.EXCEL6.Keys(id&";test-case;Failed;"&version&";;;;[Enter]")

  Else  

        Call Aliases.EXCEL.wndXLMAIN.XLDESK.EXCEL6.Keys(id&";test-case;Passed;"&version&";;;;[Enter]")

 

  End If

End Function

-----------------------------------------------------------------------------------

Function dxlexsists(ByVal id)



    If (Aliases.doors.dlgDOORSReport.btnOK.Exists) Then

        Call Aliases.doors.dlgDOORSReport.btnOK.ClickButton

        Call Aliases.doors.wndDOORSWindow1.RichEdit20W.Click(210, 40)

        Call Aliases.doors.wndDOORSWindow1.RichEdit20W.Keys("^a^c")

        Call Aliases.NOTEPAD.wndNotepad.Edit.Keys("[Enter]")

        Call Aliases.NOTEPAD.wndNotepad.Edit.Keys(id)

        Call Aliases.NOTEPAD.wndNotepad.Edit.Keys("[Enter]")

        Call Aliases.NOTEPAD.wndNotepad.Edit.Keys("^v[Enter][Enter]^s")

        Call Aliases.doors.wndDOORSWindow1.btnClose.ClickButton

      dxlexsists =  true

    Exit Function

    Else

    dxlexsists = false

    Exit Function

    End If

 End Function





That's the code

I commented all GUI-related calls and this example works for me.



Sub test()

  Dim failed

  failed = LinkParameterPosMM(1234)

  Log.Message failed

  writeproducol 4142, 8.2, failed

End Sub



This example posts "False" to the test log

I also commented all GUI-related calls.



But i still got the errormassage :



Runtime Error in VB Script

Type incompatibility: 'LinkParameterPosMM'

Unit: "testscript" Line: 3 Column: 3.



Sub test()

is writen in Unit "testscript"

Could this error occure, because all this function are inside different files?

May be. If you placed your functions to different units, then you have to declare their usage in other units. See help topic "Calling Routines and Variables Declared in Another Unit".



But before you do this, first try to put them to the one unit and make sure that it works.