Forum Discussion

ChandanD's avatar
ChandanD
Contributor
5 years ago

Unable to come out of the While loop.

Hello, I am scripting using Javascript. The function I am testing is SVN checkout. The download starts and OK button is disabled. So I have a script to check the OK button is enabled. What is does ...
  • BenoitB's avatar
    BenoitB
    5 years ago

    Please use code display to help reading. The avalialble option is visible when you click on ... and then </>

    Please put image in higher size, here we can't read it.

    Please never do test condition with assignment, it is useless as it will be always true (if name = 'blabla')

    Please explain "The test case is passed but still it checks one more time and makes the test case fail.", i don't understand, if test passed then why checking again ?

     

    What is exactly the problem with the previous code i given to you ?

    Have you tried to use breakpoint to better understand how it runs ?

     

    Your code is strange, what i understand is you loop while the process exists or name is equal to finished and in this loop you click every time.

     

    As already said this is bad method:

    - dont click continuously moreover when you told us that it can last 10 to 20 min.

    - the test condition name equal finished is the break condition so here the only effective test is the process exists

     

     

    Perhaps simply loop until the inProgress.btnOK.Enabled is equal to true (and keep a watchdog to protect yourself against infinite loop). Or use WaitProperty method.

    var btn     = inprogress.btnOK;
var maxTime = 45*60*1000; // 45 mins
if (btn.WaitProperty("Enabled", true, maxTime))
  btn.Click()
else
  throw Error("Check out not finished after 45 mins, please check manually");

     

     

     

ChandanD's avatar
ChandanD
Contributor

Hello,

 

Below is the code which I have written but still it is doing the same. Not coming out of while loop.

 

var inprogress = Aliases.TortoiseProc.dlgTrainingsvnCheckoutTortoiseSVN
var name = inprogress.WndCaption
while(name="Checkout Finished!")
{
inprogress.btnOK.Click()
name = inprogress.WndCaption
inprogress.RefreshMappingInfo()

}

BenoitB's avatar
BenoitB
Community Hero
5 years ago

 

= is assign, so your condition will be ALWAYS true because you test that the assignation is done, which is always true...

Moreover, the name variable is useless.

Then avoid continuous click without delay between to let system act/react.

 

I'm not sure, you want to wait the text Checkout finished and then click a button  OR you need to click a button till the text Checkout finished appears ?

 

This click on button until the text Checkout finished appears:

 

var inprogress = Aliases.TortoiseProc.dlgTrainingsvnCheckoutTortoiseSVN;
while (inprogress.WndCaption != "Checkout Finished!" ) {
  inprogress.btnOK.Click();
  inprogress.RefreshMappingInfo();
  aqUtils.Delay(500);
}

 

 

  • AlexKaras's avatar
    AlexKaras
    Champion Level 3
    5 years ago

    Hi,

     

    > while(name="Checkout Finished!")

    > = is assign, so your condition will be ALWAYS true

    Somewhere in time I met a book with coding recommendations... One of them was to put a constant in comparisons to the first place.

    So the above will be

    while ("Checkout Finished!" = name)

    It looks a bit unusual at first, but its idea is that this line of code will fail immediately with the error that there is attempt to assign a value to the constant. Quite effective way to prevent typos with one or two equal signs, I would say...

     

    • BenoitB's avatar
      BenoitB
      Community Hero
      5 years ago

      I think i understand the trick but i' not sure.

       

      But nevertheless this trick is dangerous because it make antinomic reading of the code (making an underlying condition with assignment) and here i don't see the advantage, or perhaps i didn't really understand the trick  ;^)

       

      Txs AlexKaras to learn me this .. or not .. or perhaps ... lol .. lost in translation i am ...

       

      • AlexKaras's avatar
        AlexKaras
        Champion Level 3
        5 years ago

        BenoitB :

        Well, it was late, so I was not crystal clear... 😉

        As an example:

        > while(name="Checkout Finished!")

        This is an assignment that will be evaluated to True. Code will execute without any error/exception and one might spend some time in debugger until the typo is noted.

         

        > while ("Checkout Finished!" = name)

        This fails immediately during runtime with the error like 'attempt to assign a value to a constant'. Code stops and the problem is clearly visible.

        For me it was not that difficult to get used to 'reverse' notation. As well as remember a simple rule: 'The constant in comparisons has to be put in the first place'.

         

        Hope that now I was more clear 🙂

         

  • ChandanD's avatar
    ChandanD
    Contributor
    5 years ago

    Hello,

     

    I shall explain in detail.

    The OK button is not enabled until the download is completed.

    It may take 10 min or 15 min or 20 min for OK button to be enabled. So I have to wait till that time frame. 

    To check download is completed, it can be done with WndCaption=Checkout Finished!

    So I am using while loop to wait for OK button to be enabled as I know the condition is WndCaption. Test complete waits for the time frame whatever it takes for OK button to be enabled. 

    It clicks the OK button but it doesn't comes out of loop. It is still in while loop searching for WndCaption and Ok button.

    Now with your script I believe it will come out immediately and it will not wait for OK button to enable.

    • BenoitB's avatar
      BenoitB
      Community Hero
      5 years ago

      Ok, so just wait for the text and then exit.

      But put a watchdog to avoid infinite loop, for example 45mn.

       

      var inprogress = Aliases.TortoiseProc.dlgTrainingsvnCheckoutTortoiseSVN;
var stopTime   = Win32API.GetTickCount() + (45*60*1000);
while (inprogress.WndCaption != "Checkout Finished!" ) {
  if (Win32API.GetTickCount() > stopTime)
    throw Error("Still not finished after security timeout, please check manually");
  aqUtils.Delay(30000);
  inprogress.RefreshMappingInfo();
}
inprogress.btnOK.Click();
      • sonya_m's avatar
        sonya_m
        SmartBear Alumni (Retired)
        5 years ago

        Thank you for helping Community!

         

        ChandanD have you tried Benoit's latest suggestion? Does it solve you issue? Please share🙂