Forum Discussion

Dewayne_Pinion's avatar
Dewayne_Pinion
Contributor
10 years ago

Returning object name from function and accessing properties/methods

Hello, This should be simple but so far I am striking out. I have a function that will search the current form for a button that I pass in as a variable:   function FindBtn(BtnName) // Pass in Nam...
  • HKosova's avatar
    HKosova
    10 years ago

    Change the FindBtn function to return the button object instead of the button's FullName:

     

     

    if (btn.exists)
{
  Log.Message(btn.Name + " was successfully found");
  return btn;
}

     

     

    Also, I think

     

    btn = p.findChild(PropName, "WinFormsObject(" + PropValue + ")", 200000, true);

    can be simplified into:

    btn = p.FindChild("NativeClrObject.Name", BtnName, 200000, true);
  • Ryan_Moran's avatar
    Ryan_Moran
    10 years ago

    As Helen pointed out you're returning the name.

    You need to return the object in your function.

    You may also want to make it a little more generic by allowing the passing of the process and property name.

    Also return an empty stub object so subsequent checks on the returned object will not fail.

     

    function FindBtn(ProcessName,PropName,PropValue) // Pass in property name and Name of Control
{
  var btn,p;  
  btn = Sys.Process(ProcessName).findChild(PropName,"WinFormsObject(" + PropValue + ")",200000,true); // Look for the button on the current form
  
  if (btn.exists)
    {
    Log.Message(btn.Name + " was successfully found.");
    return btn;
    }
  else
    {
    Log.Error("Object not found.", "Property specified: " + PropName + "\nValue specified: " + PropValue);
    return Utils.CreateStubObject();
    }
}
Ryan_Moran's avatar
Ryan_Moran
Valued Contributor

Try using .Click() instead of .ClickButton

Dewayne_Pinion's avatar
Dewayne_Pinion
Contributor
10 years ago

Hey Ryan,

I tried that as well. I do know that ClickButton() is a valid method for the control. It seems like maybe the button is being seen as a text string and needs to be converted to an object somehow so I can call the methods for it. I may be way off but I think that's what is happening.

  • Ryan_Moran's avatar
    Ryan_Moran
    Valued Contributor
    10 years ago

    As Helen pointed out you're returning the name.

    You need to return the object in your function.

    You may also want to make it a little more generic by allowing the passing of the process and property name.

    Also return an empty stub object so subsequent checks on the returned object will not fail.

     

    function FindBtn(ProcessName,PropName,PropValue) // Pass in property name and Name of Control
{
  var btn,p;  
  btn = Sys.Process(ProcessName).findChild(PropName,"WinFormsObject(" + PropValue + ")",200000,true); // Look for the button on the current form
  
  if (btn.exists)
    {
    Log.Message(btn.Name + " was successfully found.");
    return btn;
    }
  else
    {
    Log.Error("Object not found.", "Property specified: " + PropName + "\nValue specified: " + PropValue);
    return Utils.CreateStubObject();
    }
}
    • Dewayne_Pinion's avatar
      Dewayne_Pinion
      Contributor
      10 years ago

      Thanks Ryan,

      I appreciate the additional info, as that will help me extend the function out to cover our other applications that I will need to automate for at some point. I have not used the createstubobject before, I will do some reading up on that. :)

      • Ryan_Moran's avatar
        Ryan_Moran
        Valued Contributor
        10 years ago

        No problem. You could also possibly return the btn object regardless of it existing as well.

        As a matter of preference I just create an empty stub object, but the .findchild method should* do this as well if it can't find it.

        Of course this then just makes this function  little more than the .FindChild method with some logging :).

         

        function FindBtn(ProcessName,PropName,PropValue) // Pass in property name and Name of Control
{
  var btn = Sys.Process(ProcessName).findChild(PropName,"WinFormsObject(" + PropValue + ")",200000,true); // Look for the button on the current form
  
  if (btn.exists)
    {
    Log.Message(btn.Name + " was successfully found.");
    }
  else
    {
    Log.Error("Object not found.", "Property specified: " + PropName + "\nValue specified: " + PropValue);
    }

return btn;
}
  • Dewayne_Pinion's avatar
    Dewayne_Pinion
    Contributor
    10 years ago

    Helen and Ryan,

     

    Thank you both for the quick help! Helen your reply got me going. I will look at your suggestion for simplifying as well.