Forum Discussion

roc_muto's avatar
roc_muto
New Contributor
11 years ago

Automation code reviews for script and keyword tests

Hi all,



Does anyone have code reviews for your automation? Looking to improve our process and wanted to see if others were having code reviews for there automated script and/or keyword tests. 

Currently I select a subset of tests for any new hires and review them myself but I would like to implement something for everyone and off load some of that responsibility.

Thoughts?

How do you run your code reviews?



Thanks,

Roc
  • Philip_Baird's avatar
    Philip_Baird
    11 years ago

    Hi Roc, we treat every automated test the same as any development effort during a Sprint, e.g.


     


    1. A Story is written for each automated test


    2. Each automated test goes through a design phase


    3. Every automated test written has to have a peer review


    4. Automated tests are deployed


     


    We use JScript and have coding standards based on idiomatic.js (slightly modified to fit with certain Test Complete eccentricities)


     


    The peer code review asks the following questions:


     


    1. WHAT has been written, does it match the Story and design?


    2. HOW it has been written, have the coding standards been followed?


    3. WHY has it been written the way it has? not why the Test was written, but why certain patterns were used


     


    Regards,


    Phil Baird

  • Philip_Baird's avatar
    Philip_Baird
    Community Expert
    11 years ago

    Hi Roc, we treat every automated test the same as any development effort during a Sprint, e.g.


     


    1. A Story is written for each automated test


    2. Each automated test goes through a design phase


    3. Every automated test written has to have a peer review


    4. Automated tests are deployed


     


    We use JScript and have coding standards based on idiomatic.js (slightly modified to fit with certain Test Complete eccentricities)


     


    The peer code review asks the following questions:


     


    1. WHAT has been written, does it match the Story and design?


    2. HOW it has been written, have the coding standards been followed?


    3. WHY has it been written the way it has? not why the Test was written, but why certain patterns were used


     


    Regards,


    Phil Baird