Hi Colin,
See if this helps:
Hi Colin,
See if this helps:
Hi Helen
Thanks for that. That extension is pretty much what I was suggesting I would write. So saved me the trouble. :)
However, I had all sorts of problems getting an array into it (which contains the parameters) from C# Script. To get it in the right format (as far as I can tell) I would have had to use a scripting object to generate a safe array/list, then convert that to a VBArray.
Which seemed like a lot of extra hassle.
So I modified the extension script so that it took in a delimited string (using "|" as the separator as this is seldom used in SQL). Then simply used a "Split" inside the script extension to create the VB type array within the extension, rather than having to pass it in. Much easier to create a delimited string in C# Script (and thus Jscript) than a VB type array!
Works great now. Thanks.
Here is the modified extension script code:
Function CallObjectMethod(obj, method, paramIN)
Dim params, paramStr, i, result
params = Split(paramIN, "|")
paramStr = ""
For i = 0 To UBound(params)
paramStr = paramStr & "params(" & i & ")"
If i < UBound(params) Then paramStr = paramStr & ", "
Next
Execute("Call obj." & method & "(" & paramStr & ")")
CallObjectMethod = params
End FunctionGreat! Thanks for sharing your solution.
Further modified extension code, but with simple error handling now wrapped around the command that makes the execute call.
So, any failure will not crash the extension. The code has been modified slightly as I use my own framework for logging and results tracking. I've replaced that with a couple of "pseudo-lines" (if such things exists?) instead.
In my case, it's the second out parameter I'm interested in. It will always be zero or greater. So where the pseudo-lines are in the attached, in my case I set "params(1) = -1" (so the calling function knows there was a failure) and a custom log message. However, this is specific to how I'm using it to make specific SQL calls. Same method won't work if using it in other scenarios. A generic error log/return would though.
Function CallObjectMethod(obj, method, paramIN)
Dim params, paramStr, i, result
params = Split(paramIN, "|")
paramStr = ""
For i = 0 To UBound(params)
paramStr = paramStr & "params(" & i & ")"
If i < UBound(params) Then paramStr = paramStr & ", "
Next
On Error Resume Next
Err.Number = 0
Execute("Call obj." & method & "(" & paramStr & ")")
If Err.Number <> 0 Then
' LOG ERROR
' OR PASS BACK SOME SORT OF MEANINGFUL RETURN CODE FOR FAILURE
End If
On Error Goto 0
CallObjectMethod = params
End FunctionSlight drawback discovered.
If I give it invalid SQL, it crashes within the extension script and the entire project is halted as a result.
This will be driven by user populated data, so I have to be able to handle it if they populate it with bad SQL.
*sigh*
So looks like I'll need to extend the extension further to include some error handling. I can't have it crashing mid-suite ....
