Forum Discussion

michalr's avatar
michalr
Occasional Contributor
12 years ago

Stalled review detection and Waiting state - workflow bug

Hi,

we are constantly experiencing the following annoying issue with Collaborator. Here is how to reproduce:



Review has two participants Author and Reviewer.

1 Author indicates that he is waiting for the reviewer to perform his work.

2.Reviewer Approves the review.



At this moment both participants expect the review to be finished but instead they are both reactivated and an email is sent that the review is stalled, which is not true.



Is there an option to tell Collaborator not to do this and instead finish the review? Or at least reactivate just Waiting author and not the reviewer who already approved the review?



Thanks,

Michal



  • michalr's avatar
    michalr
    Occasional Contributor
    Is anybody from Smartbear reading this forum? Could you please confirm whether there is some configurations for this or if you plan to fix it in future releases? We are evaluating Collaborator for use by our company and this is a major workflow inconvenience. Being spammed and reactivated every-time will rightly annoy our devs and lessen their willingness to perform reviews.



    To reiterate the correct behaviour: If deadlock is detected just Waiting users should be reactivated. Definitely not users that had approved the review already.
  • Anonymous's avatar
    Anonymous
    Hi Michal,



    What version of CodeCollaborator are you running?

    What is your exact Next Steps Waiting status set to?



    I'm unable to duplicate this issue running the latest v.8003, setting my Next Steps Waiting state to "Any Activity Occurs". When the reviewer approves the review, the review enters the Completed phase successfully.



    If your issue persists, please open a support ticket by emailing support@smartbear.com

    and send us a review dump file so we can take a closer look.




    To create a debugging dump of the review, open the review in question, then go to the "System" link at the bottom of the page (depending on administrative settings, you may have to be an administrator to do this).


     


    In the "Server Backup/Debugging Dump" section, select the following settings:


     


    "Server Logs" => "Include Server Logs"


    "File Contents" => "Include all file content"


    "Which Data" => "Complete database dump"


    "Restrict to One Review" => "Only data from Review ID xxxx"


     


    Then click on the "Download Dump File" button.  Send me the resulting zip file.

    Thanks!

  • michalr's avatar
    michalr
    Occasional Contributor
    Thanks for the reply.



    I am using the version 8.0.8003.

    Author (user1) of the review is waiting for the "Any Activity Occurs".



    Please note that the role setting "Phase-change waits for "finished"" is set to Yes for both Author and Reviewer roles.



    I think your steps are correct, but just to be sure let me reiterate them:

    1. Author (user1) creates a review, adds user2 as a reviewer and begins the review.

    2. Author sets his state to Waiting and chooses "
    Any Activity Occurs"

    3. Reviewer (user2) clicks on Approve button.



    Result: Both users are changed to the Active state.

    Expected result: Just author is changed to the Active state and Reviewer stays in the Approved state.















  • Anonymous's avatar
    Anonymous
    Hi Michal,



    Thanks for your review dump file you send with support case 72744. I'll take a closer look and reply back in that case thread.
  • Hi,

    what was the resolution to this "waiting" state issue? We are experiencing the same issue using version 8.2.8202.



    Thanks,

    Bernard