Forum Discussion

MikeLoundes's avatar
MikeLoundes
Contributor
12 years ago

Unable to remove file

Hi

I'm having an issue with some temp files I generate being locked and I'm then unable to remove them unless I close SoapUI

I have some tests which call out to another project file which extracts some data from a backend db and creates some datasinks of csv format for use in the main test

I have the following code which is intended to remove any existing files on an iteration of data driven testing


log.info '   Deleting files'
def CurrentDir = new File(groovyUtils.projectPath).parent
def getPartyDetails = context.expand( '${#Project#GetPartyDetails}' )
def getPartyPhoneDetails = context.expand( '${#Project#GetPartyPhoneDetails}' )
def getPartyEmailDetails = context.expand( '${#Project#GetPartyEmailDetails}' )
def getPartyAddressDetails = context.expand( '${#Project#GetPartyAddressDetails}' )

[new File(CurrentDirStr+getPartyDetails), 
 new File(CurrentDirStr+getPartyPhoneDetails), 
 new File(CurrentDirStr+getPartyEmailDetails),
 new File(CurrentDirStr+getPartyAddressDetails)].
    each{ it.delete() } //delete files

log.info '   Checking files deleted'    
assert ! new File(CurrentDirStr+getPartyDetails).exists()
assert ! new File(CurrentDirStr+getPartyPhoneDetails).exists()
assert ! new File(CurrentDirStr+getPartyEmailDetails).exists()
assert ! new File(CurrentDirStr+getPartyAddressDetails).exists()



the issue I'm having is that as the main test iterates through the rows of data the ds's created are not always being removed and I end up with a mix of data in the ds that is then causing failures in my assertions when cross referencing the ds data with service response data

after running the main test If I dip into the script test step that deletes the files and run it I get the error below which shows that the file is not being deleted

Assertion failed: assert ! new File(CurrentDirStr+getPartyDetails).exists() | | | || | | | | || true | | | |SoapUI_DS_PartyDetails.csv | | | C:\Users\Public\Documents\SoapUI\SoapUI_DS_PartyDetails.csv | | C:\Users\Public\Documents\SoapUI\ | C:\Users\Public\Documents\SoapUI\SoapUI_DS_PartyDetails.csv false error at line:


is there a way of forcing a close, file release before I attempt the delete?

thanks
Mike

15 Replies

  • nmrao's avatar
    nmrao
    Icon for Champion Level 1 rankChampion Level 1
    12 years ago
    Is it the entire script or part of your script?
  • MikeLoundes's avatar
    MikeLoundes
    Contributor
    12 years ago
    Hiya

    that was part of it

    here's the full script, in the referenced test case its the first test step that's run before any of the data extraction (via jdbc datasource using sql queries) and datasink creation, the datasinks are set to append as multiple rows of data are potentially returned in any iteration


    def groovyUtils = new com.eviware.soapui.support.GroovyUtils(context)
    def CurrentDir = new File(groovyUtils.projectPath).parent
    def CurrentDirStr

    println()
    print '################# Delete Existing DS File - Party Details'
    println()

    //check to see if we're running under windows
    File Windir = new File('\\Windows')
    if (!Windir.exists())
    {
     CurrentDir = (System.getProperty("user.dir"))
     def lastChar = CurrentDir[-1] 
     if (lastChar != '/'){CurrentDir=CurrentDir+'/'}
     if (!CurrentDir.contains('/workspace/')){CurrentDir=CurrentDir+'/workspace/'}
     CurrentDirStr = CurrentDir.toString()
     testRunner.testCase.testSuite.project.setPropertyValue('UsedFilesGenericLocation',CurrentDirStr)
     print '#### Current Dir = '+ CurrentDirStr
    }
    else
    {
     def lastChar = CurrentDir[-1] 
     if (lastChar != '\\'){CurrentDir=CurrentDir+'\\'}
     CurrentDirStr = CurrentDir.toString()
     testRunner.testCase.testSuite.project.setPropertyValue('UsedFilesGenericLocation',CurrentDirStr)
     log.info CurrentDirStr
    }

    log.info '   Deleting files'
    def getPartyDetails = context.expand( '${#Project#GetPartyDetails}' )
    def getPartyPhoneDetails = context.expand( '${#Project#GetPartyPhoneDetails}' )
    def getPartyEmailDetails = context.expand( '${#Project#GetPartyEmailDetails}' )
    def getPartyAddressDetails = context.expand( '${#Project#GetPartyAddressDetails}' )

    [new File(CurrentDirStr+getPartyDetails), 
     new File(CurrentDirStr+getPartyPhoneDetails), 
     new File(CurrentDirStr+getPartyEmailDetails),
     new File(CurrentDirStr+getPartyAddressDetails)].
        each{ it.delete() } //delete files

    log.info '   Checking files deleted'    
    assert ! new File(CurrentDirStr+getPartyDetails).exists()
    assert ! new File(CurrentDirStr+getPartyPhoneDetails).exists()
    assert ! new File(CurrentDirStr+getPartyEmailDetails).exists()
    assert ! new File(CurrentDirStr+getPartyAddressDetails).exists()
  • MikeLoundes's avatar
    MikeLoundes
    Contributor
    12 years ago
    the script will run through and remove any of the files as expected as long as they're not locked but when created as part of a 'test run' when it tries to remove the files they get locked and it cant remove them

    cant remove them manually either when that happens, have to close SoapUI then they can be deleted

    hence the query about forcing them to close or be released so that they can be deleted regardless

    thanks
    Mike
  • SmartBear_Suppo's avatar
    SmartBear_Suppo
    Icon for Alumni rankAlumni
    12 years ago
    Hi,

    Can you try to add a close statement in your code before you delete the files, as follows:

    each { 
              it.close()
              it.delete()
            }

    Also, make sure the "GetPartyDetails", "GetPartyPhoneDetails", etc. do include the extension (format) of the file.

    Let me know if that solves the issue.

    Regards,

    Giscard
    SmartBear Support
  • MikeLoundes's avatar
    MikeLoundes
    Contributor
    12 years ago
    Hiya

    already tried that but I get the following


    groovy.lang.MissingMethodException: No signature of method: java.io.File.close() is applicable for argument types: () values: [] Possible solutions: list(), list(java.io.FilenameFilter), use([Ljava.lang.Object;), use(java.lang.Class, groovy.lang.Closure), use(java.util.List, groovy.lang.Closure), collect() error at line: 40
  • SmartBear_Suppo's avatar
    SmartBear_Suppo
    Icon for Alumni rankAlumni
    12 years ago
    Hi,

    I have this script working: 

    filearray = ["C:/Desktop/files/file1.txt", "C:/Desktop/files/file2.txt"]

    for ( i in filearray ){
                    def f = new File(i)
                    f.delete()
    }


    See if you can adapt it and check that CurrentDirStr is using the correct "/" separator.

    Regards,

    Giscard
    SmartBear Support
  • MikeLoundes's avatar
    MikeLoundes
    Contributor
    12 years ago
    Hiya

    the actual file delete isn't necessarily the problem as the script will delete the files (under the correct conditions)

    the issue I'm having is that during a test execution as the main test suite iterates through the rows of data sometimes the test suite that is invoked which tries to delete the files before recreating them cant delete them because they're still in use for some reason,
    the file locking isn't predictable and doesn't occur at the same time each pass through, if I run the tests through row by row all is fine (unless a validation fails which seems to see the files locked on the next pass) but when running through on a range of rows of data (even with validations being aok) at some point I end up with a file that hasn't been deleted and the file that is then referenced is an amalgam of data which will then fail the validation that references that file as the data comparison is fails
  • SmartBear_Suppo's avatar
    SmartBear_Suppo
    Icon for Alumni rankAlumni
    12 years ago
    Hi,

    Can you try to place a delay in your script to see if you can make the conditions uniform for each row as your test is executed?
    Thread.sleep(n milliseconds)

    See if you can achieve consistent results that way.

    Regards,

    Giscard
  • MikeLoundes's avatar
    MikeLoundes
    Contributor
    12 years ago
    Hi

    I'd already tried that

    I've got a work around whereby I create a new folder for each iteration through, its clunky but it works,

    preference would still be to just be able to clear existing files in a consistent fashion on each iteration through, is there no means to actually force a close of a file??
  • SmartBear_Suppo's avatar
    SmartBear_Suppo
    Icon for Alumni rankAlumni
    12 years ago
    Hi,

    If the file is locked, because SoapUI has locked the file then you will not be able to delete it. The files that are being deleted, are these created by SoapUI Pro or by you? Also, is SoapUI Pro using the files being created if they are created by you? There is a Groovy method createTempDir(String prefix, String suffix) you could use if you have to create directories.



    Regards,
    Marcus
    SmartBear Support