scline
Occasional Contributor
Joined 10 years ago
User Profile
User Widgets
Contributions
Re: Need Reference documents in a review
I totally agree. It gets confusing and authors have to add a note requesting that the support files be ignored. Half the time reviewers don't pay attention to those notes and waste time reviewing support files. johnmcdraper wrote: While performing inspections, you often need to reference other materials. Other source code files, Requirements and Design documents, etc. Currently Collaborator has no way to include these as part of a review. If you upload these reference documents, they become part of the review. The only other option is to create a custom review field and use the text field to tell people where to find the reference material. (We ended up zipping up reference material, checking it into SCM, and putting a link to the zip file in this custom text field. It would be nice to have a more elegant solution to include reference materials in with a particular review. Ideally, a way to upload these files but not make them part of the review itself.Re: Problem encountered trying to create a Collaborator review from tfs client
Forgot to add Log info: Tail of log: !ENTRY com.smartbear.collaborator.ui 4 0 2016-09-15 14:13:44.251 !MESSAGE Could not finish Review Job !STACK 0 com.smartbear.ccollab.client.CollabClientInvalidInputException: Errors found: [ { "result" : { } }, { "result" : { } }, { "errors" : [ { "code" : "AccessError", "message" : "Cannot upload changelists to a review unless you are a participant or administrator, due to review access restrictions in place." } ] } ] at com.smartbear.ccollab.client.commands.Command.sendBatch(Command.java:562) at com.smartbear.ccollab.client.commands.AbstractAddChangelistCommand.executeJson(AbstractAddChangelistCommand.java:233) at com.smartbear.ccollab.client.commands.admin.review.AbstractReviewCommand.executeJson(AbstractReviewCommand.java:208) at com.smartbear.ccollab.client.commands.Command.validateAndExecute(Command.java:414) at com.smartbear.collaborator.Collaborator.executeJson(Collaborator.java:243) at com.smartbear.collaborator.jobs.AddToReviewJob.processChanges(AddToReviewJob.java:209) at com.smartbear.collaborator.jobs.AddToReviewJob.run(AddToReviewJob.java:132) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55) SueProblem encountered trying to create a Collaborator review from tfs client
We have a program that is using TFS as the development environment. We have the TFS gui client but when we try to start a new review using a change list in TFS gui we get the following error. Any ideas? Are there some settings, credentials or something that we may have missed? Any help would be greatly appreciated. Sue ClineRe: Need transparent background on pushpin graphic
I find the opaque push pin annoying. Pins are placed in a document or code file at the point where a change occurs. Example: if I am reviewing a complicated formula in a piece of code and I find an error. I want the push pin at the point of error. If I place it in the white space at the end of a line I would likely need to copy the formula into the comment and apply the correction in order for the author and other reviewers to know that the 3rd '-' should be a '+'. Seems very inefficient.Re: Show state as "Waiting (was approved)" or similar
We use the "approved" state to know when reviewers have completed the review. We also have the settings so that all reviewers and the author must be in the approved state prior to allowing the moderator to complete a review. The fact that anytime an new comment is made or a new file is uploaded all previous approvals go away makes for gumpy developers since the moderator has to constantly remind them to approve the review.
