I want to emphasize how impossible it can be to do a review when there are a lot of defects (say 10-15 or more) across multiple uploads (basically any more than 1) because of this issue of losing track of line numbers. It gets hard for the reviewer to verify that a defect is fixed (I can't find the code change), and it gets hard for a developer to figure out what code a defect is referring to (I can't find the bad code). The failure to display the code line happens even when I am looking at the upload version against which the defect was logged (that is, I picked to compare latest upload vs the upload where I logged the defect).
This happens even when a file has had only 2 uploads (so there is the baseline version, the first upload against which the defects were logged, and the second/latest upload. The first re-review has defects re-ordering in weird ways depending on which version I am comparing. I am even stuck not being able to add a comment for a defect; when I type, it jumps to some other defect.
The only workaround I have found is to abandon the code review and start over with a new review, where hopefully the defects logged in the original review have been mostly addressed. Which is a lot of work on the reviewer to re-review the files undergoing a lot of defects.
This is turning into an almost daily battle for me, to get through increasingly difficult re-reviews. I can't believe this is being treated as an enhancement and not a bug.
Related Content
- 2 years ago
- 2 years ago