Forum Discussion

go2khurram's avatar
go2khurram
Contributor
9 years ago

Groovy If statement is not behaving as expected

I have written some code in which I am parsing the response xml of JDBC request and saving the rows in an ArrayList. "ar"   Later I am matching the return values with a watch list array called "req...
  • go2khurram's avatar
    go2khurram
    9 years ago

    Hurray....

     

    I manage to fixed this by converting the array value into integer  Herer is the sample code 

     

    ArrayList ar = new ArrayList()
jdbcXml = context.expand('${JDBCRequestForCheckingCommandPropertyID#ResponseAsXml}')
def root = new XmlSlurper().parseText(jdbcXml)
root.ResultSet.Row.each{row->
ar.add(row["COMMANDPROPERTYID"].toInteger())
}
nmrao's avatar
nmrao
Champion Level 3
9 years ago
Would put the sample xml and what exactly you need out of it?
  • go2khurram's avatar
    go2khurram
    Contributor
    9 years ago

    Here is the JDBC response XML I am parsing in my script 

     

    <Results>
    <ResultSet fetchSize="128">
        <Row rowNumber="1">
            <COMMANDID>99762022</COMMANDID>
            <COMMANDPROPERTYID>61</COMMANDPROPERTYID>
            <COMMANDTYPEID>81</COMMANDTYPEID>
            <PROPERTYVALUE>2013-11-22T00:00:00</PROPERTYVALUE>
            <LASTUPDATED>2013-11-14 12:44:15.177</LASTUPDATED>
        </Row>
        <Row rowNumber="2">
            <COMMANDID>99762022</COMMANDID>
            <COMMANDPROPERTYID>276</COMMANDPROPERTYID>
            <COMMANDTYPEID>81</COMMANDTYPEID>
            <PROPERTYVALUE>2013-11-22T00:00:00</PROPERTYVALUE>
            <LASTUPDATED>2013-11-14 12:44:15.16</LASTUPDATED>
        </Row>
       </ResultSet>
</Results>

     

     

    In the scriprt mentioned in my initial post , I am reading the COMMANDPROPERTYID values and inserting into ar ArrayList. 

    Then using the  if (ar.contains(requiredField[j]) ) statemenmt If and validating that ar elements exist in another array list requiredField . if exist then call the update step else call insert step.

     

    While testing the logic I have trim my code to below where "ar.contains(requiredField[0]) " statement works or not and surprise to know that this starement returning false even both array have value e.g 61

     

    here is the short version of the code again

    ArrayList ar = new ArrayList()
*jdbcXml = context.expand('${JDBCRequestForCheckingCommandPropertyID#ResponseAsXml}')
def root = new XmlSlurper().parseText(jdbcXml)
root.ResultSet.Row.each{row->
ar.add(row["COMMANDPROPERTYID"])
}


ArrayList requiredField = new ArrayList()
requiredField.add(61)
requiredField.add(276)
requiredField.add(605)


log.info "First Element of ar array: "+ar[0]
log.info "First Element of requiredFiled  array: "+requiredField[0]
log.info "Is ar array contains element in requiredField[0]: "+ar.contains(requiredField[0])

    Result shows using the above XML as input: 

    Thu Feb 11 14:10:36 GMT 2016:INFO:First Element of ar array: 61
    Thu Feb 11 14:10:36 GMT 2016:INFO:First Element of requiredFiled array: 61
    Thu Feb 11 14:10:36 GMT 2016:INFO:Is ar array contains element in requiredField[0]: false

     

    However if I comment the code where I am  parsing XML and add element in ar Array List , result is as expected:

     

    Is thsi something to do with data type??

     

     

    • nmrao's avatar
      nmrao
      Champion Level 3
      9 years ago
      How about this approach if I understand the question well?
      May be you can query directly for the same value using where commandpropertyid=x, then if you receive result set with 0, then insert.

      • go2khurram's avatar
        go2khurram
        Contributor
        9 years ago

        Thanks for the guidence. Actually I am querying directely.  The whole this I am doing for the test data preparation. Allow me to explain what I am doing:

         

        In Srep 1:  I am searching some command which has certain type, state description and order state by using the below query, This is from database A

        Stepname: JDBCRequestForGettingCommandInCoolingOff

         

        Select top 1 COMMANDID 
From Command with(nolock) 
Where TypeName LIKE 'Provide%' 
and commandstatedescription = 'CoolingOff'
and orderstatedescription = 'Processing'
and agentid=5
order by datereceived desc

        Step 2: Step Name: JDBCRequestForCheckingCommandPropertyID

         

         

        In this step from s differemt database "B", I am checking wherther the commandID i found in step 1 has CommandPropertyID in(61,276,605)

        Below SQL I am using for this:

        Step

         

        select * from ORTCommandPropertyData
where CommandID in ('${JDBCRequestForGettingCommandInCoolingOff#ResponseAsXml#//Results[1]/ResultSet[1]/Row[9]/COMMANDID[1]}')
and CommandPropertyID in(61,276,605)

        Because I am quering from two different databases so I have to dothis in two sepearte steps

         

         

        Step 3: Groovy Scriprt 

         

        ArrayList ar = new ArrayList()
jdbcXml = context.expand('${JDBCRequestForCheckingCommandPropertyID#ResponseAsXml}')
def root = new XmlSlurper().parseText(jdbcXml)
root.ResultSet.Row.each{row->
ar.add(row["COMMANDPROPERTYID"])

}
ArrayList requiredField = new ArrayList()
requiredField.add(61)
requiredField.add(276)
requiredField.add(605)


	for (j=0; j<requiredField.size();j++)
	{
		if (ar.contains(requiredField[j]))
		{	
				
			testRunner.gotoStepByName("Update"+requiredField[j])
		
		}
		else
		{   
		
			testRunner.gotoStepByName("Add"+requiredField[j])
		}
	}

        As you could see this scripti has 3 logical parts

         

         

        In the first part, I am parsing response xml generated in step2 and storing COMMANDPROPERTYID value in array ar.

        I have test this step separately and works fine, I manage to print this array which returns the correct value

         

        In the 2nd part I have cretaed another ArrayList  requiredField with hardcode values , so quite strightforward 

         

        In the last step where I feeling pain on the back side I am checking whether elements of ar contains in requiredField, 

         

        this if (ar.contains(requiredField[j])) returning false every time

         

        I didn't get why this is returnig false, within the else block , I printed both arrays and found that array ar also have one or more  value from set (61, 276 ,605).

         

        The whole thing I am doing is not complex but I am not sure why this giving me such a pain. :(

         

        I appriciate your help and based on above explaining I hope you will identify my mistake or suggest me some alternate.

         

        By the why i tried  by playing with quotes both in ar.add(row["COMMANDPROPERTYID"]) and requiredField.add(61) statements though might be its because of datatype mismatch if statement returning  false.