FIX in SOAP UI

Consider this: If you were running a company and decided to allow the community to contribute to your application, how many different ways / formats would you want to support for accepting patches? Where would you draw the line in legally protecting your company and cutting corners?

I created my first small fix the other day, the entire setup from zero (I did not even have a GitHub account) to submission took me 1 hour. Second time around I could probably do the same thing in 10 minutes.

Hi!

Awesome to hear that you want to contribute to the project!

The reason that we have to ask you to fill in that contributor form is because, while we love patches from the community, we can't risk anything legally (at least so says our lawyer).

Best Regards

Henrik
LoadUI developer

hi, regarding the form attached to http://www.soapui.org/Developers-Corner ... oapui.html, you can send the CLA by email
If you are interested in "the cla or not" debate, see this post http://julien.ponge.org/blog/in-defense ... greements/ and the "Further readings" paragraph in this post

momer could you provide more details (or even the 3 lines ) about the bug and the fix. I would like to know if the error exist in version prior to 4.6.0
Thanks

Hi guys,

Thanks for the replies everyone. I will fill the contributor form and send it soon. I am with the opinion that SoapUI is one of the coolest open source projects that has a big community so it is worth it.

best regards

Hi guys,

I tried to send email but apparently the email address doesn't work. I receive a mail delivery failure. Anyway, I can explain the issue here. I created a MockService in soapUi which shall accept request and return responses. I had a groovy script to handle this. It worked as expected when started from soapUi. But then when I built the war file and deployed it in a servlet container like Tomcat, the MockService was read during initialization but was not added to the list of mock runners to be started. So when a request is sent, a "log is disabled" response is received. This same request works well inside soapUi. So I cloned the soapUi repo and modified the file MockAsWarServlet.init() method. There is a loop at the bottom which goes over all mockServices and calls start. The start method creates a mockRunner object but the return type was ignored. So I stored the mockRunner in a variable and then added it to the list if not null.

         for( MockService mockService : project.getMockServiceList() )
          {
     logger.info( "Starting mockService [" + mockService.getName() + "]" );
    if( StringUtils.hasContent( mockServiceEndpoint ) )
    {
     ( ( WsdlMockService )mockService ).setMockServiceEndpoint( mockServiceEndpoint );
    }

    MockRunner mockRunner = mockService.start();
    if(mockRunner != null)
    {
        logger.info("Added a MockRunner");
         ((MockServletSoapUICore) getMockServletCore()).startMockService(mockRunner);
    }
  }

The last part which checks if the mockRunner is not null and adds it to the MockServletCore is the part that I have added. After building soapUi with this fix and creating a war file from the same mockServlet, everything is working fine.

Hi,

To contribute this fix to SoapUI please fill out the contributor agreement (in which you did from what I read in previous post) and open a support ticket at at http://www.soapui.org/Support/support-overview.html.

From there we will get in touch with you to provide the next steps.



Thanks.