git diff does not require a '--' between the revisions and path, at least not the way I'm using it. For example, I can run this command just fine, and it happily displays my diffs.
git diff 3b42 f249 path/to/specific/files
However, running ccollab addgitdiffs new 3b42 f249 path/to/specific/files tries to interpret the path as a revision, and fails. If I follow your suggestion and add the "--" ...
ccollab addgitdiffs new 3b42 f249 -- path/to/specific/files
I get a different error ...
ERROR: Executing command `ccollab addgitdiffs`:
There are no diffs to upload
My working directory is clean, but I'm trying to create a review for a diff between two already committed revisions. It's almost as if code collab is ignoring all the arguments before the path. However, it only seems to do so if a path is specified. If I just run this ...
ccollab addgitdiffs new 3b42 f249
It works just fine. So code collab is definitely mangling something before passing it along to git diff. Here are my versions of things ...
ccollab --version
ccollab v9.2.9200
git --version
git version 1.9.5 (Apple Git-50.3)
(Note: Also posted this comment on http://community.smartbear.com/t5/Collaborator/Add-Git-Diffs-with-path/m-p/115786 ... seems to be exactly the same issue)