Forum Discussion

vkessler's avatar
vkessler
12 years ago

Verify review changes were made

Does Code Collaborator provide any tools to help validate that a change was made correctly?  We are using SVN and doing post-commit reviews.



The only way we have found to validate changes is to find the file in Windows File Explorer and bring up the TortoiseSVN menu and look at the changes from there.
  • francois_roux's avatar
    francois_roux
    Occasional Contributor
    12 years ago
    You might be able to write a app that gets executed on svn pre-commit which will take the last diff in svn for the code checked in and compare that with the diff in collaborator? In theory anyway.

    Not sure if you can, by way of the collaborator API, call an external diff tool. If you can, then you can automate the whole process.



    The problem just comes in where someone else has made a change to the base code in the mean time.

     
  • venkuvenkius's avatar
    venkuvenkius
    Occasional Contributor
    12 years ago
    can you help me in precommit script , i used

    "C:\Program Files\Collaborator Client\ccollab.exe" --url <URL> --user <Username>--password <password> --scm subversion --svn-repo-path %1 --svn-look-exe "C:\Program Files\TortoiseSVN\bin\svnlook.exe" admin trigger ensure-reviewed --review-id-regex "review:\s+(\d+)" %2 || exit 1



    and getting the error as below in SVN

    Error :

    Commit failed (details follow):

    Commit blocked by pre-commit hook (exit code 1) with output:

    Your changelist message doesn't include the CodeReviewer review ID.

    You must include text that matches this Java-style regular expression:

    review:\s+(\d+)