Contributions
Keyboard automation to accept and move to review the next file.
Most times, when I look at a file in collaborator, especially a short one, I just want to accept the file, and move to the next file. Why Accept? It tells me that I looked at the file, and places a green checkmark in the review. Useful for long review, and not losing what was reviewed and what not. It tells the Author that I actually looked at the file – communicating that I felt it was important to look and review it. Collaborator makes this simple thing VERY CHALLENGING using the keyboard alone, so I have a workaround. You need to install the Chrome Vimium extension for this to work, and have the aText keystroke recorder/player The key thing is that PageUp will remove the input focus from the Overall comment edit control, and thus allow Vimium to work. On my system I record the following keystrokes: PageUp (The editor has the input focus, this key removes it) f (this invokes the vimium find - overlaying keystrokes to press in order to achieve a button press sk (this is the code for the Accept overall displayed in Vimium) -- at this point there is an exchange with the server, so you have to put in wait. Ctrl + ] moves you to the next File in the review. Voila, you activate your macro via keyboard sequence (there's a hotkey to find the last used snipped), and it automatically accepts the file, and moves to the next file. Friedrich Brunzema562Views0likes0CommentsRe: Please add a keyboard shortcut to "File Mark Accepted, Overall"
Also the pop-up messages that ask to either go to the top of the file (modal dialog) are disruptive, since there are no keystrokes to for Yes or No, and remember the choice does not seem to work consistently. This dialog is a nuisance the way it is now.5.6KViews0likes0CommentsPlease add a keyboard shortcut to "File Mark Accepted, Overall"
Subject says it all: Please add a keyboard shortcut to "File Mark Accepted, Overall". We use the mark file as accepted for two reasons -- keeping track of where you are in the review -- what files you've seen and which ones you have not. Also to communicate to the stakeolders we did, in fact look at each file. My current workaround is to enable accessibility features (under windows) to allow me to use a keystroke to "click" using MouseKeys. Ideally, it would be good to have an overhaul of the functionality of doing reviews with the keyboard. Why not have all the navigation, acceptance done on the numeric keypad (with num-lock off). 8=previous change 2=next change 4=previous file 6=next file 5=Mark accepted (file) If you decide to do this, do usability testing on the feature. Repetitive keystrokes should be "close to each other" like "next file" and Next Change and Mark as accepted. Another thing that could be improved is marking files as accepted in bulk. For instance on some reviews we may get 50 or so files that get deleted. Marking them accepted is very tedious.5.6KViews1like1Comment[CodeReviewer] Exclude binary files from review
Hi, sometimes we check in .dll and .exe files as part of a changeset along with the sources. Is it possible to tell code collaborator not to add specified binary file extensions to the review (i.e not upload them to the server and not having them as part of the review process). Thanks, F.1.4KViews0likes2Comments