Any comment drops "Approved" state of the code review

Question

In Collaborator 10 any comment drops "Approved" state of the code review back into "Active" state. So, if person A reviewed and signed it off, and then person B leaves some comment, state of the person "A" becomes "Active" again.

Is it bug or feature? As for me - it does not make any sense at all. I remember, it did not behave that way in Collaborator 9. Is it possible to make it work the old way? Comments should not trigger state of code review.

alexeykryuchkov · Answer

Hi Artem,
&nbsp;
It looks like this behavior can be changed by setting the Required to read all comments to No for Reviewer.

antoinell · Answer

We are using Code Collaborator 10.0.10000 and this information does not seem to be correct. We have "Required to Read all Comments" set to No for reviewer in our two active role configurations (used by our templates). There is a third role configuration called "Formal Inspection" but our templates do not use it. "Formal Inspection" has the "Required to Read all Comments" set to Yes for reviewer.

samir_patel · Answer

Hi Alexey,
&nbsp;
We are using 11.2.11200 and when I tried to modify this field to be "no" and save, we get an error message "Error: Invalid input: Role Description: You cannot edit role fields because this template is being used in a Review!". So how can we disable and yet keep same Role configuration with exception of "Required to read all comments" to be "No" for reviewer and observer?
&nbsp;
Thanks
Samir

alexeykryuchkov · Answer

Hi,
&nbsp;
I experimented on the latest version of Collaborator (10.2.10200), so I recommend that you try using it too.

yimy · Answer

Hi Samir,
&nbsp;
Unfortunately, it is not possible to edit roles that are associated with templates, which are currently being used in reviews.
However, you could create a new role with only that difference.
This would be my suggestion:1. Create a new Role with the required rules/settings.&nbsp;2. Go to the templates setting and Edit the desire template, and scroll all the way down to find the "Roles" section.&nbsp;3. From the drop-down list of the "Roles:" field you can choose the newly created role.&nbsp;4. Save the change.&nbsp;Once you save it, Collaborator will create a copy of the current template with the new role and it will disable the old one that had the other(previous) role.
&nbsp;
This will not affect exisiting reviews created in the past.
&nbsp;
Thanks!
Yimy&nbsp;

Forum Discussion

Any comment drops "Approved" state of the code review

5 Replies

Related Content

Add a "Ready for Approval" state to defects

Collaborator feature request: allow "sticky" approval for reviewer

Show state as "Waiting (was approved)" or similar

Move implemented ideas off the "Approved for Discussion"

All comments in feature file printed to console

Recent Discussions

Migrate Review Templates

How does a participant indicate they are finished with the current phase?

Cannot open individual projects

Changing role settings

Collaborator - Automatic Links