My team uses Pull requests within Bitbucket Server and have configured Collaborator to merge the pull request when a review has completed. Unfortunately we have found that if the merge fails, the review still successfully completes.
When this occurs we need to:
- manually re-open the review
- have the developer resolve the problem that prevented the merge from completing (fix the CI build, fix the merge conflict, etc)
- re-approve the review and send-to-completed again
The Bitbucket plugin will then re-attempt the merge.
When attempting to close a review, Collaborator should wait for Bitbucket to attempt the merge and if it fails, the review should remain open and all review participants should be notified.
